Reject external versioning when script is configured in OpenSearch sink#6773
Merged
dinujoh merged 1 commit intoApr 29, 2026
Merged
Conversation
dinujoh
requested review from
KarstenSchnitter,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
reviewed
Apr 22, 2026
| } | ||
|
|
||
| if (scriptConfiguration != null && openSearchSinkConfig.getVersionType() != null | ||
| && VersionType.External.jsonValue().equalsIgnoreCase(openSearchSinkConfig.getVersionType())) { |
Member
There was a problem hiding this comment.
Does OpenSearch accept this with different case? External, eXternal, EXTERNAL?
If not we should require strict equality.
Member
Author
There was a problem hiding this comment.
OpenSearch only accepts external (lowercase) for version_type. The VersionType.External.jsonValue() returns external. I will make this fix
OpenSearch does not support external versioning with scripted upserts. Add config-time validation in IndexConfiguration to fail fast with a clear error message instead of getting runtime 400 errors from OpenSearch. Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>
dinujoh
force-pushed
the
fix/reject-external-version-with-script
branch
from
98521f6 to
cadaea2
Compare
kkondaka
approved these changes
Apr 28, 2026
sb2k16
approved these changes
Apr 28, 2026
simonelbaz
pushed a commit
to simonelbaz/data-prepper
that referenced
this pull request
Apr 29, 2026
…nk (opensearch-project#6773) OpenSearch does not support external versioning with scripted upserts. Add config-time validation in IndexConfiguration to fail fast with a clear error message instead of getting runtime 400 errors from OpenSearch. Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenSearch does not support external versioning with scripted upserts. Add config-time validation in IndexConfiguration to fail fast with a clear error message instead of getting runtime 400 errors from OpenSearch.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.